Add namespacing and PSR-4 style autoloader#295
Merged
Conversation
cffa8f5 to
ee9ef1c
Compare
- Add Indieweb namespace with Hcard and Relme subnamespaces - Add WordPress-compatible autoloader (class- prefix style) - Modernize main plugin file structure (singleton pattern) - Add INDIEWEB_VERSION constant - Remove strict_class_file_names phpcs exception New structure: - Indieweb\Autoloader - Indieweb\Indieweb (main plugin class) - Indieweb\Plugin_Installer - Indieweb\General_Settings - Indieweb\Integrations - Indieweb\Hcard\User - Indieweb\Hcard\Author_Widget - Indieweb\Relme\Domain_Icon_Map - Indieweb\Relme\Widget
ee9ef1c to
e66d966
Compare
Member
Author
|
@dshanske any ideas on that one? |
Member
|
Everything looks good, was still thinking about the icon question...let me focus on this so we can merge it and I'll keep thinking. |
Member
Author
|
@dshanske what do you mean by "let me focus on this so we can merge it and I'll keep thinking". do you think this PR is depending on the icons? |
Member
|
No, I'm saying that I was thinking about the other discussion and didn't think enough about this one. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Indiewebnamespace withHcardandRelmesubnamespacesINDIEWEB_VERSIONconstantstrict_class_file_namesphpcs exceptionNew Structure
Test plan
composer lintto confirm PHPCS passes